Repository navigation
Conversation
Author
|
@somexpert @ldko This is ready for review. Thoughts? Note: this also needs to be updated on PyPI after we merge. 😄 |
ldko
reviewed
Sep 22, 2026
ldko
left a comment
ldko
left a comment
Member
There was a problem hiding this comment.
Looking good. A couple changes requested. Thanks!
Comment on lines
-14
to
-16
| entry_points={ | ||
| 'console_scripts': ['edtf-validate=edtf_validate.valid_edtf:main'], | ||
| }, |
Member
There was a problem hiding this comment.
This needs to be brought over to pyproject.toml. See comment about project.scripts.
somexpert
reviewed
Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #37